PR Reviews

Jeeva Ramachandran
2 replies
What are the things should be considered while reviewing a PR?

Replies

Hidayt Rahman
Its a big thing to describe but I follow the below point Best practices, reusability, and perfomances
Amir Andohkosh
One of the most important (and maybe obvious) points I learned that helped me become a better reviewer was to not think how I would have implemented but whether the PR meets the criteria that was set out. I also make a lot of effort to make the tone friendly which makes a huge differece. Having the mindset of wanting to learn and maybe teach also changes perspective and tone and helps make it more effective and enjoyable for both parties!